commit f73e12fe96b66cc36470acc39d88a23b96744a37 Author: David King Date: Mon Mar 9 23:20:28 2015 +0000 Update NEWS for 2.3.5 release M NEWS M SOURCES M configure.ac commit bba87b66f8ee584630965a55496905ea56535a1e Author: Marek Černocký Date: Sun Mar 1 19:31:26 2015 +0100 Updated Czech translation M po/cs.po commit 17491cdbbfc022c15cb98db4cacaaff9a029d1a3 Author: David King Date: Mon Feb 23 21:14:16 2015 +0000 Add bug reference to File_Tag test M tests/test-file_tag.c commit 3fc01f03d7730524cf02ede2e9adcf1f5df70dde Author: David King Date: Mon Feb 23 19:04:04 2015 +0000 Use versioning guards for tests Simplify test declaration by factoring out the common variables, and add the versioning guards to those. M Makefile.am commit 1eca256c4f4b67d38c4dcdb93a658e9f9f26edf9 Author: David King Date: Mon Feb 23 18:53:10 2015 +0000 Reinstate versioning guards for GLib and GTK+ These were accidentally dropped when migrating to AX_COMPILER_FLAGS. M Makefile.am M configure.ac commit 89e7cb0190ff6970987bd6be6795bd936f5edf30 Author: David King Date: Sun Feb 22 16:08:12 2015 +0000 Remove some unnecessary finalize() overrides M src/load_files_dialog.c M src/playlist_dialog.c M src/preferences_dialog.c M src/search_dialog.c commit 57512213ef1cb3a708fafadefaaf0294aee1bf53 Author: Piotr Drąg Date: Sun Feb 22 20:46:45 2015 +0100 Updated Polish translation M po/pl.po commit 9ae72de9596dbe5715a949912fed73b1d626d80a Author: David King Date: Sun Feb 22 13:29:58 2015 +0000 Add a test for et_file_tag_copy_other_into() M src/file_tag.c M tests/test-file_tag.c commit 678d0b977387d32951d08f5fcc7d1569ce6ba328 Author: Ting-Wei Lan Date: Sun Feb 22 12:51:21 2015 +0800 Fix "void function should not return a value" https://bugzilla.gnome.org/show_bug.cgi?id=744928 M src/application_window.c commit aba60f35e96ecfbc5a5b4c9ccb834aeed670bfdc Author: David King Date: Sun Feb 22 12:43:19 2015 +0000 Fix a memory leak when freeing the history list M src/file_list.c commit f3f403cd4e2168f4bbc1fb650357c3ea73102ff5 Author: David King Date: Sun Feb 22 12:14:28 2015 +0000 Fix memory leak in et_file_list_add() M src/file_list.c commit f899d24f97e770dc6188367d0cff08fe849baa8d Author: David King Date: Sun Feb 22 11:58:01 2015 +0000 Avoid some unnecessary tag area string copying When applying tags to a selection, avoid using gtk_editable_get_chars(), which copies the entry content, and instead use gtk_entry_get_text(), which returns a const pointer to the entry string. M src/tag_area.c commit 1781770285c0f65bcb6d0e7dc805b12831d0c7cd Author: David King Date: Sun Feb 22 10:54:36 2015 +0000 Clarify a string in the scanner dialog legend As reported by Tristan Scott. M data/scan_dialog.ui commit 40abf34fa235dcb5527f326bdf772b87b9773bc8 Author: David King Date: Sat Feb 21 23:12:05 2015 +0000 Use et_str_empty() in several more places There are many instances of strlen() being used to check for an empty string, which can be replaced with et_str_empty(). M src/browser.c M src/cddb_dialog.c M src/playlist_dialog.c M src/scan_dialog.c M src/tag_area.c commit 87d56bb8e4013ab1afde622f74317b56d92033c5 Author: David King Date: Sat Feb 21 22:48:32 2015 +0000 Add simple test for et_str_empty() M tests/test-misc.c commit afa3ed43e88762179339bdfad137c21d123deb8f Author: David King Date: Sat Feb 21 22:39:56 2015 +0000 Convert most g_utf8_strlen() to new et_str_empty() Nearly all uses of g_utf8_strlen() were to check that a string was not empty. The check for empty was often paired with a check that the char pointer was not NULL. Simplify the combination of checks into a new et_str_empty() function, which returns TRUE if either the supplied char pointer is NULL or the string is empty. Leave checks that are only concerned with one of the two checks as they are, but remove g_utf8_strlen() where possible. M src/browser.c M src/cddb_dialog.c M src/file.c M src/load_files_dialog.c M src/misc.c M src/misc.h M src/playlist_dialog.c M src/scan_dialog.c M src/setting.c M src/tag_area.c M src/tags/ape_tag.c M src/tags/flac_tag.c M src/tags/id3_tag.c M src/tags/ogg_tag.c commit 60657a082be24cb131c41d0284d67a4f475b636b Author: David King Date: Sat Feb 21 20:45:04 2015 +0000 Remove unused static variables M src/browser.c M src/misc.c M src/scan_dialog.c commit eaeb1453d75e122ccb6c228db46afbda8950d3b2 Author: David King Date: Sat Feb 21 20:21:35 2015 +0000 Move string length define from header to source M src/cddb_dialog.c M src/easytag.h commit af0a7687a2226f011fa5000c47f88986316c91f0 Author: David King Date: Sat Feb 21 18:05:32 2015 +0000 Add a simple test for et_normalized_strcmp0() M tests/test-misc.c commit 834b354f5ddf438ee58fa5824ea7b7849eb05e1e Author: David King Date: Sat Feb 21 17:54:42 2015 +0000 Add a function for comparing UTF-8 strings Comparing strings for equality with g_utf8_collate() gives a poor result, as it is intended for ordering, not equality comparisons. It is preferable to normalize the string first, and then to compare the normalized result. Add a new et_normalized_strcmp0() function to do this, and use it in et_file_tag_detect_difference() to avoid problems where two strings compared identically with g_utf8_collate(), which prevented the user from changing tag fields. Adapt the File_Tag test as appropriate. https://bugzilla.gnome.org/show_bug.cgi?id=744897 M src/file_tag.c M src/misc.c M src/misc.h M tests/test-file_tag.c commit 8e51def2639137056a0f3ebe845986a2934143da Author: David King Date: Sat Feb 21 16:49:08 2015 +0000 Add File_Tag tests M Makefile.am A tests/test-file_tag.c commit d5ec560efd040fcb065907678a819ec513e51920 Author: David King Date: Sat Feb 21 16:25:13 2015 +0000 Add a simple undo key test M tests/test-misc.c commit af47e0762d646d72b77c77d5f1de234bbaa22095 Author: David King Date: Sat Feb 21 16:20:20 2015 +0000 Move undo key generation to misc.c This should make it easier to write tests. M src/file.c M src/file.h M src/file_list.c M src/file_name.c M src/file_tag.c M src/misc.c M src/misc.h commit 6671ad6aa83456325dceaef32e276748f205abad Author: David King Date: Sat Feb 21 16:05:35 2015 +0000 Use g_build_filename() in a couple more places M src/browser.c M src/scan_dialog.c commit 2c202d8e884da7d0749cf907f22c15de204f64b5 Author: David King Date: Sat Feb 21 11:16:31 2015 +0000 Simplify application window file list navigation Factor out the common code to a separate function. M src/application_window.c commit 480514bf6375efdaf310c8f299241346b8aa2c1e Author: David King Date: Sat Feb 21 11:07:06 2015 +0000 Update AX_COMPILER_FLAGS from autoconf-archive M m4/ax_compiler_flags.m4 M m4/ax_compiler_flags_cflags.m4 commit dc2d03daa4924aaa02ab7065ebc46b4fec9ae716 Author: David King Date: Sat Feb 21 11:05:54 2015 +0000 Tighten invariants when navigating the file list M src/application_window.c commit 8702b04364ff590c3181ffbbeeb11b5a49e2cb16 Author: David King Date: Sat Feb 21 10:52:31 2015 +0000 Use ET_Set_Filename_File_Name_Item() Rather than setting File_Name fields directly, use the existing helper function. M src/file_list.c commit b0c6e89c56e5877fd8398d3a4511bec9767ca4d5 Author: David King Date: Thu Feb 19 23:27:23 2015 +0000 Move filename updating code to application window Remove GTK+ calls from the ET_File code. M src/application_window.c M src/file.c M src/file.h M src/file_name.c M src/file_name.h commit 1a8b1b757f719b16a5a3a62fc9309b743e1b408b Author: David King Date: Thu Feb 19 22:30:25 2015 +0000 Factor out common file renaming code Refactor ET_Save_File_Name_Internal() and ET_Save_File_Name_From_UI() to use a new et_file_name_set_from_components(), and reduce code duplicatoin slightly. M src/file.c commit 95dc22cef21b1ed78ccdba4021e4f472bab384b5 Author: David King Date: Thu Feb 19 20:32:05 2015 +0000 Move ET_Display_File_Data_To_UI() to main window Rename ET_Display_File_Data_To_UI() to et_application_window_display_et_file() and move it to EtApplicationWindow. M src/application_window.c M src/application_window.h M src/browser.c M src/cddb_dialog.c M src/easytag.c M src/file.c M src/file.h M src/load_files_dialog.c M src/scan_dialog.c M src/tag_area.c commit 5daf401c2586ef974139b9e1f96044a585d3d078 Author: David King Date: Thu Feb 19 18:34:56 2015 +0000 Add et_application_window_update_et_file_from_ui() Refactor existing code, which directly called ET_Save_File_Data_From_UI() against ETCore->ETFileDisplayed, to instead call the new function. Additionally, handle the case that ETCore->ETFileDisplayed is NULL, and do not call the function, avoiding triggering an invariant check. M src/application_window.c M src/application_window.h M src/browser.c M src/cddb_dialog.c M src/easytag.c M src/load_files_dialog.c M src/scan_dialog.c M src/tag_area.c commit 9704e1117c36fe893088a71669b9e7f570cf4c27 Author: David King Date: Thu Feb 19 17:46:46 2015 +0000 Remove dead assignment in CDDB dialog Found with the Cland statix analyzer. M src/cddb_dialog.c commit 01563bb62de675d49d6810f659939057de9b627b Author: David King Date: Wed Feb 18 22:54:09 2015 +0000 Add ifdefs around private FLAC code Fix compilation when FLAC support is not enabled. https://mail.gnome.org/archives/easytag-list/2015-February/msg00004.html M src/tags/flac_private.c commit 92ed3c29cc4bde93ba9f2250e3ecaccad23bcf38 Author: Marek Černocký Date: Mon Feb 16 22:39:14 2015 +0100 Updated Czech translation M po/cs.po commit 83b4a66ad564f0eba58edcb0c2a742b556781d7f Author: David King Date: Mon Feb 16 19:18:50 2015 +0000 Update AX_COMPILER_FLAGS with --disable-Werror https://bugzilla.gnome.org/show_bug.cgi?id=744616 M m4/ax_compiler_flags.m4 M m4/ax_compiler_flags_cflags.m4 M m4/ax_compiler_flags_cxxflags.m4 M m4/ax_compiler_flags_gir.m4 commit 14070f7df03e543b591c5dbc7b28683a6a916299 Author: Kjartan Maraas Date: Mon Feb 16 20:12:09 2015 +0100 Updated Norwegian bokmål translation from Åka Sikrom. M po/nb.po commit dc11af6b42f456fae92844f3a1cdccc57597eab3 Author: Piotr Drąg Date: Sun Feb 15 18:35:38 2015 +0100 Updated Polish translation M po/pl.po commit 6c50d0e0242a32b0b8fdca588cd15d98c7ce2e07 Author: David King Date: Sat Feb 14 20:12:37 2015 +0000 Set the GError in et_id3tag_check_if_file_is_valid If the file was empty, but there were otherwise no errors when reading the file, the GError was left unset. This caused a crash, when reading the error message for display to the user and dereferencing a NULL pointer. M src/tags/id3_tag.c commit ca7a1e6f8725df854c4dff41e066bda16d23b7de Author: David King Date: Sat Feb 14 20:07:39 2015 +0000 Mark a UI string as translatable M src/file_list.c commit 13844449f413a66410d230e4494011b15513a484 Author: David King Date: Sat Feb 14 20:02:28 2015 +0000 Check for a valid MP3 file when reading the header The check to avoid an infinite loop in id3lib with an empty file was only run when reading ID3 tags, not when reading the header information. M src/tags/id3_tag.c M src/tags/id3_tag.h M src/tags/mpeg_header.c commit 34e64fd011a7ea4126223a36c5ba97e2f984bec5 Author: David King Date: Sat Feb 14 19:55:03 2015 +0000 Refactor et_id3tag_check_if_file_is_corrupted() Fit the usual convention of setting the GError when returning FALSE, by renaming the function to et_id3tag_check_if_file_is_valid(). M src/tags/id3_tag.c commit 5cb07a6b41a3ac86625040824c9ca475f06f4dd4 Author: David King Date: Sat Feb 14 00:00:01 2015 +0000 Remove an unnecessary include M src/et_core.c commit d81075d63435a0402bb9dbfac5c3c1801a13df49 Author: David King Date: Fri Feb 13 23:27:27 2015 +0000 Remove an unused variable in ET_Core M src/et_core.h M src/file_list.c commit fc4526c271bc0a3634b235850f10f17f520a6651 Author: David King Date: Fri Feb 13 23:01:41 2015 +0000 Add a trivial ET_File_Info test M Makefile.am A tests/test-file_info.c commit e859c35a810d0688fdba434952611f8671974eda Author: David King Date: Fri Feb 13 22:13:27 2015 +0000 Avoid a crash when reading FLAC files with no tags https://bugzilla.gnome.org/show_bug.cgi?id=744497 M src/tags/flac_tag.c commit b92a6305602ea1d363560473b072a97c6ad363b1 Author: David King Date: Fri Feb 13 19:58:22 2015 +0000 Add a test for et_filename_prepare() M tests/test-misc.c commit 97385362051bebd8960137310ac8999648f49b70 Author: David King Date: Fri Feb 13 18:41:05 2015 +0000 Refactor ET_File_Name_Convert_Character() Move ET_File_Name_Convert_Character() to misc.c and rename it et_filename_prepare(). Take a boolean argument for whether to replace illegal characters, rather than using a setting. M src/cddb_dialog.c M src/file.c M src/file.h M src/load_files_dialog.c M src/misc.c M src/misc.h M src/scan_dialog.c commit d9ce201e78e42993c7bac186fbd109fd801c2ee7 Author: David King Date: Fri Feb 13 18:24:37 2015 +0000 Move File_Name to a separate file M Makefile.am M src/cddb_dialog.c M src/file.c M src/file.h M src/file_list.c A src/file_name.c A src/file_name.h M src/load_files_dialog.c M src/scan_dialog.c M src/tags/flac_tag.c M src/tags/id3_tag.c commit e8d9f1ba1526c12ff474b55616f363e36d2d34b3 Author: David King Date: Fri Feb 13 17:22:22 2015 +0000 Split ET_File_Info off to a separate file M Makefile.am M src/core_types.h M src/file.c M src/file.h A src/file_info.c A src/file_info.h M src/file_list.c commit bedea331602546237690d98c01f86e3a7d36f133 Author: David King Date: Thu Feb 12 22:56:38 2015 +0000 Remove unused Makefile variable M Makefile.am commit c5b4c2a3ed78851153da64247e223bbefadf6c9a Author: David King Date: Thu Feb 12 22:53:37 2015 +0000 Pass AX_COMPILER_FLAGS warning flags to the linker M Makefile.am commit 9803a41db5d4ee530286f6af15cad7f572afdae6 Author: David King Date: Thu Feb 12 22:50:18 2015 +0000 Enable compiler warnings for Nautilus extension M Makefile.am M nautilus-extension/nautilus-easytag.c commit 8d75031bdfc79a20f77417e92c9e688c101496bf Author: David King Date: Thu Feb 12 22:44:43 2015 +0000 Remove unused variable from configure summary M configure.ac commit 616154f3a53c29b3c63a40921bf8ee8ef9a623ba Author: David King Date: Thu Feb 12 22:44:28 2015 +0000 Update SOURCES for 2.3.4 release M SOURCES commit 8f4cd655595f7067f44ba6541cce527bb1cec6ea Author: David King Date: Thu Feb 12 17:30:58 2015 +0000 Correctly update the artwork description An EtPicture was fetched from the model containing all the images for a file, and the description was updated depending on what the user entered into the artwork properties dialog. However, the updated EtPicture (which was a copy of the one in the model, as EtPicture is a boxed type and was fetched from the model with gtk_tree_model_get()) was not set on the model, and so any change to the description was lost on exiting the dialog. Include the EtPicture as part of the gtk_list_store_set() call when closing the dialog, and update the description correctly. M src/tag_area.c commit 7c2d6467b66c9863100b12ae5f5e919e66c6a5e2 Author: David King Date: Thu Feb 12 17:30:36 2015 +0000 Fix memory leak in artwork types dialog M src/tag_area.c commit dd7ee206c5755e9c8d80193510b690350cc964c6 Author: David King Date: Wed Feb 11 17:49:16 2015 +0000 Handle empty descriptions in ID3 tag artwork https://bugzilla.gnome.org/show_bug.cgi?id=744295 M src/tags/id3v24_tag.c commit e3f197aae814354925b3528260efbdb4115e657e Author: ChrisiPK Date: Wed Feb 11 11:46:59 2015 +0000 Fix CDDB requests being truncated EasyTAG does not handle the chunked encoding and truncates lines that fall on chunk boundaries. Make HTTP requests with 1.0 as the protocol version, to avoid a chunked transfer encoding. https://bugzilla.gnome.org/show_bug.cgi?id=743812 M src/cddb_dialog.c commit 6879d49ad2969fe25db928dba3c9164ffdd8294e Author: Osman Karagöz Date: Wed Feb 11 10:33:06 2015 +0000 Updated Turkish translation M po/tr.po commit 70e049b83bd5185883b55707a981b3b64f36c11a Author: Marek Černocký Date: Sun Feb 8 23:21:02 2015 +0100 Updated Czech translation M po/cs.po commit 1a775b1c0605e360ac6f1363c38fc774a0cb6d88 Author: Piotr Drąg Date: Sun Feb 8 13:56:52 2015 +0100 Updated Polish translation M po/pl.po commit 69f6bb575c0368bbe658d03b43533cbf7577ee6e Author: David King Date: Sat Feb 7 21:27:46 2015 +0000 Fix format warnings caused by incorrect sign GCC 5.0 now warns about using %d as a format specifier for an unsigned int. M src/application.c M src/cddb_dialog.c M src/easytag.c M src/file.c M src/file_area.c M src/file_list.c M src/misc.c M src/tag_area.c M src/tags/libapetag/apetaglib.c commit 5df5c6193c51cdc77feefde05a26161a9d715c7e Author: David King Date: Sat Feb 7 09:55:52 2015 +0000 Add missing break in playlist dialog switch Found with Coverity (CID 1268296). M src/playlist_dialog.c commit 5b8659a80ece30fb7353ac68c3381d8f7d5123d0 Author: David King Date: Sat Feb 7 09:52:59 2015 +0000 Return a value from et_artist_album_list_add_file Use g_return_val_if_fail() rather than g_return_if_fail(), and return an empty list of no ET_File is supplied. Found with Coverity (CID 1268295). M src/file_list.c commit 54ba8cf11c92650ab20d33670df66144c6ee2e67 Author: David King Date: Fri Feb 6 20:43:33 2015 +0000 Add checks for extra id3lib declarations Fix compilation of id3lib wrapper on Debian, which includes some C wrapper functions which were not in the id3lib 3.8.3 release, by checking for the declarations with AC_CHECK_DECLS. M configure.ac M src/tags/id3lib/id3_bugfix.h