commit d463f42495484437de8cec69bea9b6814ee32479 Author: Daiki Ueno Date: 2019-09-30 Release 3.34.0 NEWS | 6 ++++++ configure.ac | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) commit ddacb9cd6eff3363350252ccb976f9245a0fb729 Merge: f609501e e8291902 Author: Daiki Ueno Date: 2019-09-26 Merge branch 'glib-2-62' into 'master' Remove tap-gtester, rely on GLib 2.38+ built-in TAP output instead See merge request GNOME/gnome-keyring!20 commit e8291902185e02a20f4542b40c3fdb3a9f07a13b Author: Simon McVittie Date: 2019-09-13 Remove tap-gtester, rely on GLib 2.38+ built-in TAP output instead GLib 2.62+ outputs TAP by default, which breaks the tap-gtester script's expectations. In older GLib versions since 2.38, --tap is an opt-in to the TAP output mode, so use that. This is essentially the same issue as https://github.com/cockpit-project/cockpit/pull/11998 (cockpit was the source of the tap-gtester script), GNOME/gcr!19, and GNOME/libsecret!5. Signed-off-by: Simon McVittie Bug-Debian: https://bugs.debian.org/940157 Makefile.am | 3 +- build/tap-gtester | 206 ------------------------------------------------------ 2 files changed, 1 insertion(+), 208 deletions(-) commit f609501e986809a5d1a7f0450e9d82144e04da17 Merge: bb7336cf bf04c455 Author: Daiki Ueno Date: 2019-09-24 Merge branch 'wip/dueno/ubsan' into 'master' build: Fix UB spotted by UBSan See merge request GNOME/gnome-keyring!24 commit bf04c45535dc9fae80d3beead16fcd760989b44e Author: Daiki Ueno Date: 2019-09-16 pkcs11: Fix load of misaligned address pkcs11/gkm/gkm-attributes.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) commit 10a3663d10a9326cde76f7cfd7cb57efbd7e5e9c Author: Daiki Ueno Date: 2019-09-16 egg-asn1x: Avoid signed integer overflow egg/egg-asn1x.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) commit fb69d6ca6cb6fe290f1473c961bbf1379966d83a Author: Daiki Ueno Date: 2019-09-16 egg: Fix undefined behavior on excessive left shift egg/egg-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb7336cf262acaefe2c462ce052ecf14739d15de Author: Rafael Fontenelle Date: 2019-09-21 Update Brazilian Portuguese translation po/pt_BR.po | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) commit c58579dc4c9b5e073d2a0fc9e8a776a13fb52d5a Author: Rafael Fontenelle Date: 2019-09-19 Update Brazilian Portuguese translation po/pt_BR.po | 328 +++++++++++++++++++++++++++++++----------------------------- 1 file changed, 168 insertions(+), 160 deletions(-) commit 5738abd235f53d505bee0925ab983255720865d0 Merge: 7447cd7f 5d088356 Author: Daiki Ueno Date: 2019-09-05 Merge branch 'wip/benzea/possible-race-fixes' into 'master' Possible race fix See merge request GNOME/gnome-keyring!19 commit 5d088356a9473c06564bd2cef18ca370437a17bc Author: Benjamin Berg Date: 2019-05-14 dbus-environment: Make Setenv request synchronuous Currently there is a potential race condition where the Setenv request races further session startup. i.e. the clients that are started with --start on login may quit before the Setenv DBus call is delivered. This opens a theoretical race condition where gnome-session is already past the initialization phase when it serves the Setenv request. daemon/dbus/gkd-dbus-environment.c | 62 ++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 32 deletions(-) commit 8a948b3ac17f7d1b0ff31b0cf22e655054eb5c6b Author: Benjamin Berg Date: 2019-05-14 dbus-environment: Log Setenv call failure after initialization When the GNOME session is already initialized at the point that Setenv is called, then an error is returned. Hidding this error makes it hard to understand why the environment was not setup if things failed. daemon/dbus/gkd-dbus-environment.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 7447cd7f2b561870ca236724a4826b0857d6ff94 Author: Danial Behzadi Date: 2019-09-02 Update Persian translation po/fa.po | 600 +++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 300 insertions(+), 300 deletions(-) commit 37881eceae00ddaa89e4f06328b2beecc06a24a4 Author: Sveinn í Felli Date: 2019-08-16 Update Icelandic translation po/is.po | 554 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 281 insertions(+), 273 deletions(-) commit d8df9de406c88ddd20ce3c954947edb8fdd71563 Author: Daiki Ueno Date: 2019-08-13 build: Add .dir-locals.el for Emacs .dir-locals.el | 1 + 1 file changed, 1 insertion(+) commit 97e70eb49c7fdd2bd6f0a6b485a7adf04d5d685a Author: Jor Teron Date: 2019-07-25 Add Karbi translation po/LINGUAS | 1 + po/mjw.po | 508 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 509 insertions(+) commit 28a8b9243ceaede00d0c30318d38deb1a6c5840b Merge: 1b6742ac 198d7036 Author: Daiki Ueno Date: 2019-05-15 Merge branch 'wip/dueno/madvise' into 'master' build: Remove configure check for MADV_DONTDUMP Closes #30 See merge request GNOME/gnome-keyring!17 commit 198d70364554dea570033aded74b339d1dc1d3a1 Author: Daiki Ueno Date: 2019-05-15 build: Remove configure check for MADV_DONTDUMP It can be checked in the source code instead. configure.ac | 8 -------- egg/egg-secure-memory.c | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) commit 1b6742acc9984f15665b8dba0a654e616426cb62 Merge: e6822428 7a8b7d2e Author: Daiki Ueno Date: 2019-05-10 Merge branch 'wip/dueno/musl' into 'master' rpc-layer: fix build with musl-libc Closes #29 See merge request GNOME/gnome-keyring!16 commit 7a8b7d2ebfbb831840e6d58dbb1109f4c31d6ba4 Author: Daiki Ueno Date: 2019-05-10 rpc-layer: fix build with musl-libc The recent POSIX suggests to include for select(). Reported by Anthony G. Basile. pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c | 1 + 1 file changed, 1 insertion(+) commit e6822428ebfe3b61bfa5df7e04a5e1af7f2048ca Author: Matthew Garrett Date: 2019-04-19 egg: Request that secure memory not be dumped to disk Linux 3.4 added support for the MADV_DONTDUMP option to madvise(), which requests that the covered memory not be included in coredumps. It makes sense to use this to prevent cases where application crashes could result in secrets being persisted to disk or included in dumps that are uploaded to remote servers for analysis. I've avoided making this fatal since there's a chance this code could be built on systems that have MADV_DONTDUMP but run on systems that don't. configure.ac | 8 ++++++++ egg/egg-secure-memory.c | 13 +++++++++++++ 2 files changed, 21 insertions(+) commit 91bc9368ca2eedef0dec3f5aa81f641ced07a9b6 Author: Simon McVittie Date: 2019-03-09 test-gkd-ssh-agent-service: Avoid race condition with server thread These tests create a server thread in setup() and join it in teardown(), but there are various race conditions between them that can cause the test to hang. These are particularly reproducible when building on a single-CPU machine or VM, and particularly in the startup_shutdown test (which doesn't do anything, so it runs teardown() immediately after setup()). It's possible to get this preemption pattern: ___ Main thread ___ ___ Server thread ___ g_thread_new() (starts) g_cond_wait() (blocks) ... g_cond_signal() (gets preempted here) exit setup() enter teardown() g_main_loop_quit() g_main_loop_run() which means g_main_loop_run() will never terminate, because it wasn't running yet when the main thread told the GMainLoop to quit, and the main thread won't tell it to quit again. One way to solve this would be for the server thread to signal test->cond from an idle callback instead of directly from server_thread(), to guarantee that the GMainLoop is already running. However, it seems easier to reason about if we avoid GMainLoop and iterate the main context directly. Signed-off-by: Simon McVittie Bug-Debian: https://bugs.debian.org/909416 daemon/ssh-agent/test-gkd-ssh-agent-service.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) commit af8f5e7479f3ac8c34278caadc7a8507f96a74c0 Author: Waldo Luís Ribeiro Date: 2019-03-16 Update British English translation po/en_GB.po | 481 +++++++++++++++++++++++++++++++----------------------------- 1 file changed, 250 insertions(+), 231 deletions(-) commit 8b7f6a5df0566ab5bf4d4c1feb68963df3d7cd1f Author: Jiri Grönroos Date: 2019-03-02 Update Finnish translation po/fi.po | 356 +++++++++++++++++++++++++++++---------------------------------- 1 file changed, 165 insertions(+), 191 deletions(-)